Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics and revamp logic #206

Merged
merged 50 commits into from
Apr 5, 2022
Merged

Add metrics and revamp logic #206

merged 50 commits into from
Apr 5, 2022

Commits on Mar 15, 2022

  1. Add metrics and revamp logic 

    Declare prometheus metrics in gossipsub

Add missing metric labels

Fix metrics types

Add onReportValidation
    @dapplion
    dapplion committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    5162d70 View commit details
    Browse the repository at this point in the history

  2. Compile tests

    @dapplion
    dapplion committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    92ca5cb View commit details
    Browse the repository at this point in the history

  3. Fix tests

    @dapplion
    dapplion committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    515a55e View commit details
    Browse the repository at this point in the history

  4. Customize await policy

    @dapplion
    dapplion committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    8b6378b View commit details
    Browse the repository at this point in the history

  5. Run prettier on files

    @dapplion
    dapplion committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    a72e4ed View commit details
    Browse the repository at this point in the history

  6. Relax heartbeat test condition

    @dapplion
    dapplion committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    6b37825 View commit details
    Browse the repository at this point in the history

  7. Re-add util package for browser testing

    @dapplion
    dapplion committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    1aeae56 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2022

  1. Remove unused dependencies

    @dapplion
    dapplion committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    665d049 View commit details
    Browse the repository at this point in the history

  2. Add getMeshPeers

    @dapplion
    dapplion committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    13e510d View commit details
    Browse the repository at this point in the history

  3. Fix rpc metric name

    @dapplion
    dapplion committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    68e81e8 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2022

  1. Improve metrics

    @dapplion
    dapplion committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    a40e9a9 View commit details
    Browse the repository at this point in the history

  2. More gossip promise metrics

    @dapplion
    dapplion committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    79e934b View commit details
    Browse the repository at this point in the history

  3. Fix metrics typo

    @dapplion
    dapplion committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    109c5a1 View commit details
    Browse the repository at this point in the history

  4. Clarify metrics names

    @dapplion
    dapplion committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    c5f60d7 View commit details
    Browse the repository at this point in the history

  5. Track metric of score deltas

    @dapplion
    dapplion committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    d35cc6e View commit details
    Browse the repository at this point in the history

  6. Fix score metrics

    @dapplion
    dapplion committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    ea7c285 View commit details
    Browse the repository at this point in the history

  7. Add buckets for gossipsub_score_cache_delta

    @dapplion
    dapplion committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    6103695 View commit details
    Browse the repository at this point in the history

  8. Review PeerScore logic

    @dapplion
    dapplion committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    475bfda View commit details
    Browse the repository at this point in the history

  9. Dump peer stats

    @dapplion
    dapplion committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    af59ed4 View commit details
    Browse the repository at this point in the history

  10. Fix PeerStats constructor

    @dapplion
    dapplion committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    4f9e11c View commit details
    Browse the repository at this point in the history

  11. Enable strict typescript checks

    @dapplion
    dapplion committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    130c16a View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2022

  1. Fix compute-score logic

    @dapplion
    dapplion committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    d70e923 View commit details
    Browse the repository at this point in the history

  2. f

    @dapplion
    dapplion committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    f9b587c View commit details
    Browse the repository at this point in the history

  3. Fix peer stats types

    @dapplion
    dapplion committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    16568f0 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2022

  1. Reenable go-gossipsub tests (#201) 

    * Add checkReceivedSubscriptions

* Add checkReceivedSubscriptions to 'test gossipsub multihops'

* Add checkReceivedSubscriptions to 'test gossipsub tree topology'

* test gossipsub star topology with signed peer records

* Fix 'test gossipsub direct peers'

* Fix 'test gossipsub flood publish'

* Fix 'test gossipsub star topology with signed peer records'

* 'direct peers' test: wait for subscriptions event again

* 'direct peer': await for 2 peer:connect events

* 'direct peers': add missing Promise.all

* Expect topic peers to contain peer id
    @twoeths @dapplion
    twoeths authored and dapplion committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    51917ce View commit details
    Browse the repository at this point in the history

  2. Fix test types

    @dapplion
    dapplion committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    6fd5811 View commit details
    Browse the repository at this point in the history

  3. Set as connected in addPeer()

    @dapplion
    dapplion committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    8b4c0d1 View commit details
    Browse the repository at this point in the history

  4. Prune publishedMessageIds

    @dapplion
    dapplion committed Mar 19, 2022
    Configuration menu
    Copy the full SHA
    7ef0e8f View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2022

  1. Fix markFirstMessageDelivery typo

    @dapplion
    dapplion committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    cbbb790 View commit details
    Browse the repository at this point in the history

  2. Same logic in scoreMetrics

    @dapplion
    dapplion committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    8419b56 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2022

  1. More metrics for p3 and p7 (#213) 

    * Add behaviourPenalty metrics

* Add duplicateMsgDelivery metric

* Observe topic and peer in duplicateMsgDelivery topic

* Remove peerId from duplicateMsgDelivery metric

* Use min meshMessageDeliveriesWindow

* Use topic label for duplicateMsgDelivery metric

* Record duplicateMsgDelivery in all cases
    @twoeths
    twoeths authored Mar 22, 2022
    Configuration menu
    Copy the full SHA
    d469111 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2022

  1. Forward messages to floodsub peers (#214) 

    * Forward messages to floodsub peers

* Add comments

Co-authored-by: Lion - dapplion <[email protected]>
    @twoeths @dapplion
    twoeths and dapplion authored Mar 23, 2022
    Configuration menu
    Copy the full SHA
    2ca29fa View commit details
    Browse the repository at this point in the history

  2. Add missing msgId in validateReceivedMessage (#215)

    @twoeths
    twoeths authored Mar 23, 2022
    Configuration menu
    Copy the full SHA
    2cc6be0 View commit details
    Browse the repository at this point in the history

  3. Fix 'test gossipsub opportunistic grafting'

    @twoeths
    twoeths committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    575199c View commit details
    Browse the repository at this point in the history

  4. Fix tests in browser

    @twoeths
    twoeths committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    8a75b41 View commit details
    Browse the repository at this point in the history

  5. Fix tests suspended issue in browsers

    @twoeths
    twoeths committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    535ca58 View commit details
    Browse the repository at this point in the history

  6. Merge code from master

    @twoeths
    twoeths committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    70c3528 View commit details
    Browse the repository at this point in the history

  7. Fix 'test gossipsub fanout expiry' go-gossipsub test

    @twoeths
    twoeths committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    ca7733f View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2022

  1. GossipsubIWantFollowupTime as a param (#216)

    @twoeths
    twoeths authored Mar 24, 2022
    Configuration menu
    Copy the full SHA
    92b40f9 View commit details
    Browse the repository at this point in the history

  2. Increase resolution of delay metrics (#217)

    @dapplion
    dapplion authored Mar 24, 2022
    Configuration menu
    Copy the full SHA
    6b99dbf View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2022

  1. Fix minMeshMessageDeliveriesWindow (#218) 

    * Fix minMeshMessageDeliveriesWindow

* Fix gossipsubIWantFollowupTime for metric

* Fix tracer prune()

* Change to maxMeshMessageDeliveriesWindow
    @twoeths
    twoeths authored Mar 25, 2022
    Configuration menu
    Copy the full SHA
    61f64d1 View commit details
    Browse the repository at this point in the history

  2. Use maxMeshMessageDeliveriesWindowSec for metric

    @twoeths
    twoeths committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    14e9d6b View commit details
    Browse the repository at this point in the history

  3. Rename gossipsubIWantFollowupMs option, revert/correct tracer.prune()… 

    … logic
    @twoeths
    twoeths committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    0514022 View commit details
    Browse the repository at this point in the history

  4. Reset behaviourPenalty histogram to track current count

    @dapplion
    dapplion committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    21a79e9 View commit details
    Browse the repository at this point in the history

  5. publish(): return number of sent peers

    @twoeths
    twoeths committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    2bcf74f View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2022

  1. Add getScore()

    @twoeths
    twoeths committed Mar 27, 2022
    Configuration menu
    Copy the full SHA
    b4dbc07 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2022

  1. makePrune: update PeerStat so that we don't apply p3 penalty

    @twoeths
    twoeths committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    949a8f3 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2022

  1. Remove redundant this.score.prune() in heartbeat

    @twoeths
    twoeths committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    ba0755e View commit details
    Browse the repository at this point in the history

  2. Track iasked cache size per heartbeat and remove TODOs

    @twoeths
    twoeths committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    9e93427 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2022

  1. validateReceivedMessage: check duplicate message first (#223)

    @twoeths
    twoeths authored Apr 4, 2022
    Configuration menu
    Copy the full SHA
    b8693c5 View commit details
    Browse the repository at this point in the history