feat: add more configuration options #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are many options currently set by constants. This is limiting when applications want to override these for application-specific networks. Several interesting options are now overridable via the constructor: - heartbeatInterval - fanoutTTL - mcacheLength - mcacheGossip - seenTTL
dapplion
approved these changes
Sep 13, 2021
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
=======================================
Coverage 76.58% 76.58%
=======================================
Files 2 2
Lines 1905 1905
Branches 144 142 -2
=======================================
Hits 1459 1459
Misses 446 446 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many options currently set by constants.
This is limiting when applications want to override these for
application-specific networks.
Several interesting options are now overridable via the constructor:
These options are optional with fallback values defaulting to the prior "constant" values.