don't throw ErrProducerEquivocated if authored blocks have different parents

[kishansagathiya]

Changes

Waiting on some spec related clarification

Tests

go test -tags integration github.com/ChainSafe/gossamer

Issues

Fixes #2682

Primary Reviewer

@timwu20

[codecov]

Codecov Report

Merging #2709 (40d0c1f) into development (531f0aa) will increase coverage by 0.11%.
The diff coverage is 72.85%.

Additional details and impacted files

@@               Coverage Diff               @@
##           development    #2709      +/-   ##
===============================================
+ Coverage        63.14%   63.25%   +0.11%     
===============================================
  Files              219      219              
  Lines            27563    27590      +27     
===============================================
+ Hits             17404    17452      +48     
+ Misses            8545     8525      -20     
+ Partials          1614     1613       -1     

[qdm12]

Also would you be able to add a test case to cover such condition?
Or are unit tests messy such that's it's not easily feasible?

[noot]

i think the whole equivocation check is wrong, afaik equivocation for block producers is defined as authoring two blocks in the same slot. we're allowed to author multiple blocks w the same number as long as they're in different slots, but the check is currently checking for multiple blocks w the same number, instead of multiple blocks in the same slot

[kishansagathiya]

afaik equivocation for block producers is defined as authoring two blocks in the same slot.

Seems right. Will edit equivocation check accordingly.

https://github.com/paritytech/substrate/blob/8e600ee0515122667cd091d632104708d343ca34/client/consensus/slots/src/aux_schema.rs#L53

[timwu20]

afaik equivocation for block producers is defined as authoring two blocks in the same slot.

Seems right. Will edit equivocation check accordingly.

https://github.com/paritytech/substrate/blob/8e600ee0515122667cd091d632104708d343ca34/client/consensus/slots/src/aux_schema.rs#L53

@kishansagathiya is this PR ready for review then?

[kishansagathiya]

@timwu20 made it draft, have to re-do equivocation logic after noot's comments

[github-actions]

🎉 This PR is included in version 0.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀