Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib/trie): Make sure writing and reading a trie to disk gives the same trie and cover more store/load child trie related test cases #2302

Merged
merged 27 commits into from
Mar 22, 2022
+106 −45
Merged

fix(lib/trie): Make sure writing and reading a trie to disk gives the same trie and cover more store/load child trie related test cases #2302

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
47b6d27
Cover more store/load child trie related test cases
kishansagathiya Feb 16, 2022
29ace8a
test error `failed to insert child trie with root` in trie.Load
kishansagathiya Feb 21, 2022
772b6c2
temp
kishansagathiya Feb 22, 2022
061b9bf
test TestGetStorageChildAndGetStorageFromChild with non-empty trie
kishansagathiya Mar 3, 2022
bf0f5ee
tackle the case when encoding and hash is same
kishansagathiya Mar 3, 2022
46af47a
Merge branch 'development' into kishan/task/trie-test
kishansagathiya Mar 3, 2022
8a5f18c
so far things work, no error finding any nodes, child tries get
kishansagathiya Mar 7, 2022
e4f434a
child tries don't have empty bits in their encoding
kishansagathiya Mar 7, 2022
13f3e59
cleaning up
kishansagathiya Mar 7, 2022
d6d5a87
more clean up
kishansagathiya Mar 7, 2022
4eed767
accept []byte key in trie.Load instead of common.Hash
kishansagathiya Mar 7, 2022
c24a76d
uncomment the test TestLoadWithChildTriesFails
kishansagathiya Mar 7, 2022
d6f63bd
more clean up
kishansagathiya Mar 7, 2022
46d590c
more cleanup
kishansagathiya Mar 8, 2022
68e4469
remove mockleaf
kishansagathiya Mar 8, 2022
82db221
Merge branch 'development' into kishan/task/trie-test
kishansagathiya Mar 10, 2022
42d1532
fix the commit
kishansagathiya Mar 10, 2022
2dd3a2c
fix(lib/trie): Make sure writing and reading to disk gives the same t…
kishansagathiya Mar 14, 2022
f174ab9
Merge branch 'development' into kishan/task/trie-test
kishansagathiya Mar 14, 2022
fe91011
Merge branch 'kishan/task/trie-test' of github.com:ChainSafe/gossamer…
kishansagathiya Mar 14, 2022
019953b
remove todos
kishansagathiya Mar 15, 2022
ccca175
Update lib/trie/child_storage.go
kishansagathiya Mar 17, 2022
03af4b0
Update dot/state/storage_test.go
kishansagathiya Mar 17, 2022
9d4f195
Update dot/state/storage.go
kishansagathiya Mar 18, 2022
d6cfcc2
addressed reviews
kishansagathiya Mar 18, 2022
31d2b8e
Merge branch 'kishan/task/trie-test' of github.com:ChainSafe/gossamer…
kishansagathiya Mar 18, 2022
5c7ec38
renaming Test to keyValue
kishansagathiya Mar 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update dot/state/storage_test.go 
Co-authored-by: Quentin McGaw <[email protected]>
@kishansagathiya @qdm12
kishansagathiya and qdm12 authored Mar 17, 2022
commit 03af4b0146a87199804a15785bb8a3fdb6499c39
1 change: 0 additions & 1 deletion dot/state/storage_test.go
View file
Original file line number Diff line number Diff line change
@@ -202,7 +202,6 @@ func TestGetStorageChildAndGetStorageFromChild(t *testing.T) {

trieState, err := runtime.NewTrieState(genTrie)
require.NoError(t, err)
fmt.Printf("genTrie.RootNode().GetHash() %s\n", genTrie.RootNode().GetHash())

header, err := types.NewHeader(blockState.GenesisHash(), trieState.MustRoot(),
common.Hash{}, 1, types.NewDigest())