testing (dot/core): rewrite message.go unit tests #2197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimjbrettj
requested review from
EclesioMeloJunior,
edwardmack,
kishansagathiya,
noot,
qdm12 and
timwu20
as code owners
Codecov Report
@@ Coverage Diff @@
## jimmy/coreIntegrationTests #2197 +/- ##
=============================================================
Coverage ? 59.73%
=============================================================
Files ? 210
Lines ? 27371
Branches ? 0
=============================================================
Hits ? 16349
Misses ? 9320
Partials ? 1702
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
qdm12
approved these changes
Jan 17, 2022
noot
reviewed
Jan 17, 2022
| txs := make([]*transaction.ValidTransaction, 2) | ||
|
|
||
| mockTxnStateEmpty.EXPECT().PendingInPool().Return([]*transaction.ValidTransaction{}) | ||
| mockTxnState.EXPECT().PendingInPool().Return(txs) |
There was a problem hiding this comment.
wait why is the transaction state returning a slice with nil transactions?
There was a problem hiding this comment.
Cuz I'm only testing the length function, so i thought it would be good to have a test case testing empty input. Can remove that case if that's preferred
noot
reviewed
Jan 17, 2022
jimjbrettj
force-pushed
the
jimmy/coreIntegrationTests
branch
from
4b18eab to
55fd785
Compare
…lue (#2143) * fix: return error if result already has an assigned value * chore: include unit test * chore: fix typo `ErrResultAlreadySet` * chore: remove unneeded `require.Error` * chore: fix undeclared name * chore: remove packaged scope var to avoid problems with result type * chore: fix result.Set error at offchain test
jimjbrettj
force-pushed
the
jimmy/coreMessageUnitTests
branch
from
e70b2ee to
ec7b7ff
Compare
qdm12
reviewed
Jan 19, 2022
qdm12
reviewed
Jan 20, 2022
qdm12
approved these changes
Jan 20, 2022
qdm12
approved these changes
Jan 21, 2022
dot/core/messages.go
Outdated
| @@ -41,56 +78,29 @@ func (s *Service) HandleTransactionMessage(peerID peer.ID, msg *network.Transact | |||
| return false, err | |||
| } | |||
|
|
|||
| isValid := true | |||
There was a problem hiding this comment.
nit perhaps rename to allTxsAreValid? 🤔
| Value: peerset.BadTransactionValue, | ||
| Reason: peerset.BadTransactionReason, | ||
| }, | ||
| id: peer.ID("jimbo"), |
timwu20
approved these changes
Jan 21, 2022
jimjbrettj
added a commit
that referenced
this pull request
Jan 21, 2022
…ssage.go` unit tests (#2224) * chore(pkg/scale): return error if `Result` already has an assigned value (#2143) * fix: return error if result already has an assigned value * chore: include unit test * chore: fix typo `ErrResultAlreadySet` * chore: remove unneeded `require.Error` * chore: fix undeclared name * chore: remove packaged scope var to avoid problems with result type * chore: fix result.Set error at offchain test * migrate core tests to integration tests * remove test.log * upgrade integration tests to match dev * testing (dot/core): rewrite message.go unit tests (#2197) * chore(pkg/scale): return error if `Result` already has an assigned value (#2143) * fix: return error if result already has an assigned value * chore: include unit test * chore: fix typo `ErrResultAlreadySet` * chore: remove unneeded `require.Error` * chore: fix undeclared name * chore: remove packaged scope var to avoid problems with result type * chore: fix result.Set error at offchain test * test txt count and generate mocks with mockgen * WIP/hanldeTxnMsgTest * WIP/core message tests * wip/finish core message tests * wip/message test * fix reporting issue * test core messages * remove comments and lint * remove unused file * wip/cr feedback * use dummy error for tests * wip/finish cr feedback * wip/move message validation to a separate function * move txn validity check to new func * lint * fix variable naming to make less confusing * remove pointer from validateTxn helper params * refactor tests to define mocks in subtest * CR feedback * finish feedback for core tests * define runtime mocks in subtest * remane validTxn var Co-authored-by: Eclésio Junior <[email protected]> * CR feedback * finish feedback * CR feedback Co-authored-by: Eclésio Junior <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
Issues
Primary Reviewer