-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lib/grandpa): update grandpa catch-up process; add submodule, use NeighbourMessages #1554
Conversation
…/update-grandpa-messages
…ossamer into noot/grandpa-catch-up
…t auths from GrandpaState
Codecov Report
@@ Coverage Diff @@
## development #1554 +/- ##
===============================================
- Coverage 60.62% 58.94% -1.68%
===============================================
Files 202 185 -17
Lines 27286 19404 -7882
===============================================
- Hits 16541 11438 -5103
+ Misses 8845 5980 -2865
- Partials 1900 1986 +86
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
It seems that the GRANDPA catch-up mechanism was implemented before request/response protocols were defined. I believe that these messages should be sent as "request notifications" and "response notifications". |
Changes
catchUp
submodule to track status of catch up and deal with sending out catch-up requests and handling responsesNeighbourMessage
s to trigger catch-up process if neededTests
Issues