Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gossipsub handling to process only when in follow state #845

Merged
merged 3 commits into from
Nov 11, 2020

Conversation

austinabell
Copy link
Contributor

Summary of changes
Changes introduced in this pull request:

  • Issue is now the bitswap interactions are a bit broken when requesting messages, and it's stalling the chain_sync polling thread
    • This PR does not solve the underlying issue, we will still run into this when we get into follow state, but this check needs to be in place anyway (shouldn't handle gossip events outside of follow state) and I added a TODO and will create an issue for solving the greater issue

Reference issue to close (if applicable)

Closes

Other information and links

@austinabell austinabell added Status: Needs Review Type: Bug Something isn't working labels Nov 11, 2020
@austinabell austinabell merged commit 3c8a57b into main Nov 11, 2020
@austinabell austinabell deleted the austin/fixgshandle branch November 11, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants