Cron system actor #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
GregTheGreek,
ansermino,
dutterbutter and
ec2
ec2
approved these changes
Dec 9, 2019
ansermino
approved these changes
Dec 10, 2019
GregTheGreek
approved these changes
Dec 10, 2019
dutterbutter
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are the most up to date and the following 2 system actor PRs will not change anything but the system actors themselves. As you can see I came to terms with the fact that panics will happen and it will have to be caught from where the invocation is called. This will probably be more clear when the structure is more setup with #67 and surrounding changes