-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file reading and writing #54
Conversation
Please add toml support, we don't really need to read strings afaik. |
I think this might be for things like saving the peerID of yourself to a file? |
That is correct, I'll also add toml support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You didn't include this module in the lib.rs so it wasn't being compiled/tested.
Add:
pub mod utils;
to the node/src lib.rs file. You'll notice there are a few linting issues with private functions not being used
Afaik keys are stored in raw bytes not strings |
It doesn't seem we're actually using the key, rather only using the pubkey as a way to self identify. Which from what I know can be stored as a string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
besides type as austin pointed out, lgtm
New Features:
.toml
to structTests:
Misc:
clock
tests undernode/tests
rather than being in the respective moduleclock
public