Remove bitvec dependency and other bit field changes #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
approved these changes
Jun 29, 2020
ec2
approved these changes
Jun 30, 2020
| @@ -134,7 +137,7 @@ impl BitField { | |||
| /// Returns an iterator over the indices of the bit field's set bits if the number | |||
| /// of set bits in the bit field does not exceed `max`. Returns an error otherwise. | |||
| pub fn bounded_iter(&self, max: usize) -> Result<impl Iterator<Item = usize> + '_> { | |||
| if max <= self.len() { | |||
| if self.len() <= max { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main changes:
bitvecdependency as well as theRlePlus::{encode, decode}methods because we no longer need themBitReaderandBitWriter, they were already tested through general bit field tests but now it's much more thoroughrleplus!andbitfield!macros to easily create bit fields for testing purposes (which loosely replace thebitvec!macro)Minor stuff:
RlePlus'sDebugimplementationRlePlus'sPartialEqimplementationFromIterator<bool>andFromIterator<usize>implementations toRlePlusandBitFieldBitWriter::finish