fix: progress rates were overcounted by 5x #3919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemmih
requested review from
ruseinov and
hanabi1224
and removed request for
a team
hanabi1224
approved these changes
Jan 30, 2024
LesnyRumcajs
previously approved these changes
Jan 30, 2024
src/utils/io/progress_log.rs
Outdated
| @@ -233,14 +235,14 @@ mod tests { | |||
| progress.last_logged_items = 1024 * 1024 * 1024 / 3; | |||
| assert_eq!( | |||
| progress.msg(now + Duration::from_secs(125)), | |||
| "test 512 MiB / 1 GiB, 50%, 170.7 MiB/s, elapsed time: 2m 5s" | |||
| "test 512 MiB / 1 GiB, 50%, 1.4 MiB/s, elapsed time: 2m 5s" | |||
There was a problem hiding this comment.
Could you please explain why the speed is 1.4 MiB/s? It'd be nice to have a comment with the math regarding the expectations.
There was a problem hiding this comment.
Thanks for adding comments, that helps.
LesnyRumcajs
approved these changes
Feb 2, 2024
ruseinov
approved these changes
Feb 3, 2024
Co-authored-by: Hubert <[email protected]>
hanabi1224
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
time_in_secondsto get the real progress in units per second.Reference issue to close (if applicable)
Closes
Other information and links
Change checklist