Market actor implementation #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dutterbutter
requested review from
ansermino,
austinabell and
ec2
as code owners
austinabell
suggested changes
Apr 9, 2020
ec2
reviewed
Apr 10, 2020
ec2
reviewed
Apr 10, 2020
ec2
reviewed
Apr 10, 2020
|
CI is broken because you reverted the submodule changes after you merged in commit 5c6ccee To fix either undo that commit, or just cd into that submodule and do a git pull (pretty sure the latter should work if you commit the change, but it may not if you have the submodule cached locally) |
austinabell
reviewed
Apr 10, 2020
austinabell
suggested changes
Apr 10, 2020
austinabell
suggested changes
Apr 10, 2020
vm/actor/src/builtin/market/mod.rs
Outdated
Comment on lines
353
to
365
| let epoch_value = params | ||
| .sector_expiry | ||
| .checked_sub(rt.curr_epoch()) | ||
| .ok_or_else(|| { | ||
| ActorError::new( | ||
| ExitCode::ErrIllegalArgument, | ||
| format!( | ||
| "invalid sector expiry epoch {:?} ahead of current {:?}", | ||
| params.sector_expiry, | ||
| rt.curr_epoch() | ||
| ), | ||
| ) | ||
| })?; |
There was a problem hiding this comment.
I know this may sound weird, but you actually need to do
.checked_sub(..).unwrap_or(1u8)
lol
I thought through the logic and their impl doesn't error when this value is negative, so this needs to succeed, divide 0 by a valid number and return successfully and/or panic on a divide by 0
austinabell
approved these changes
Apr 10, 2020
austinabell
suggested changes
Apr 10, 2020
austinabell
approved these changes
Apr 10, 2020
ec2
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #264
Other information and links