Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Option
orNone
in rust. They were checking the nil if bytes are empty, which doesn't translate to Rust or how we had our types setup.remove(0)
because that impl expects a valid serializationEdit: Also updates EPoStProof serialization as discussed, and removed the tests that were statically setup for the old serialization
Edit2: Added test runner for block header serialization vectors, but the vectors were a little broken so I switched the submodule to be my fork for now
Reference issue to close (if applicable)
Closes
Other information and links