Adding Verification Function for Aggregate BLS Signatures #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RajarupanSampanthan
requested review from
ansermino,
austinabell,
dutterbutter and
ec2
as code owners
austinabell
suggested changes
Feb 23, 2020
|
|
austinabell
suggested changes
Feb 24, 2020
Comment on lines
+264
to
+266
| let signatures: Vec<BlsSignature> = (0..num_sigs) | ||
| .map(|x| private_keys[x].sign(data[x])) | ||
| .collect(); |
austinabell
approved these changes
Feb 25, 2020
There was a problem hiding this comment.
What are others thoughts on the api for the function? From what I've seen all data that is signed in Cids so maybe the data input should be a slice of Cids to avoid having to convert to bytes before calling this? Also does anyone have thoughts on if we should be using the external Public key type also instead of bytes or we alias/ create our own type for pub keys?
I'm fine with this coming in as in but would be nice to iron down the function signature/ a specific test vector when it gets used
ec2
approved these changes
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Issues with pull Request :