Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap to asyncronous_codec and bump futures_cbor_codec #1163

Merged
merged 2 commits into from
Jun 14, 2021

Conversation

ec2
Copy link
Member

@ec2 ec2 commented Jun 14, 2021

Summary of changes
Changes introduced in this pull request:

  • This fixed our nightly builds breaking

Reference issue to close (if applicable)

Closes

Other information and links

@ec2 ec2 requested a review from a user June 14, 2021 13:48
Copy link
Contributor

@cryptoquick cryptoquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, nice! This obsoletes #1154, correct?

@ec2
Copy link
Member Author

ec2 commented Jun 14, 2021

Wow, nice! This obsoletes #1154, correct?

Yep!

@cryptoquick
Copy link
Contributor

Alright, feel free to merge, but only after you verify that nightly-build-check passes.

@ec2 ec2 merged commit 446bea4 into main Jun 14, 2021
@ec2 ec2 deleted the ec2/bump-futures-cbor-codec branch June 14, 2021 14:42
@cryptoquick cryptoquick mentioned this pull request Jun 14, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants