Import/Export StateTree for Testing #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec2
requested review from
connormullett,
creativcoder and
cryptoquick
as code owners
creativcoder
approved these changes
May 26, 2021
There was a problem hiding this comment.
This will shave a lot of time on our state migration testing. Thanks a lot @ec2
ghost
approved these changes
May 27, 2021
ghost
reviewed
May 27, 2021
| let state_root = forest_car::load_car(self.blockstore(), reader) | ||
| .await | ||
| .map_err(|e| Error::Other(format!("Import StateTree failed: {}", e.to_string())))?; | ||
| if state_root.len() != 1 { |
There was a problem hiding this comment.
You could use pop and if it returns a None variant return the error. This will get rid of indexing.
|
I guess, we need to move these methods out of chain. We require the import/export methods in interpreter crate ( error: cyclic package dependency: package `chain v0.1.0 (/home/ubuntu/forest/blockchain/chain)` depends on itself. Cycle:
package `chain v0.1.0 (/home/ubuntu/forest/blockchain/chain)`
... which is depended on by `interpreter v0.1.0 (/home/ubuntu/forest/vm/interpreter)`
... which is depended on by `chain v0.1.0 (/home/ubuntu/forest/blockchain/chain)` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links