Add Prometheus server #1098
Merged
Add Prometheus server #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
connormullett,
creativcoder,
cryptoquick and
ec2
as code owners
ec2
approved these changes
May 10, 2021
creativcoder
approved these changes
May 12, 2021
cryptoquick
reviewed
May 12, 2021
| use std::io::prelude::*; | ||
| use std::path::PathBuf; | ||
| use std::sync::Arc; | ||
|
|
There was a problem hiding this comment.
Thank you for separating these out! I usually do them in the opposite order, though, but either way, it really helps vs mixing them in. I also do similar in Cargo.toml and use # to separate them.
There was a problem hiding this comment.
Yeah, I would really like it if this was part of our style guide
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Adds a Prometheus HTTP server to the
forestprocess to support the collection of metrics.This PR does not add metrics to
forest, it only sets up the metrics scaffolding.Reference issue to close (if applicable)
Closes #1095
Other information and links