This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Adding an option to hide the seed phrase #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…king the showSeedPhraseInput visible.
|
|
mpetrunic
suggested changes
Jan 17, 2022
BeroBurny
approved these changes
Jan 17, 2022
There was a problem hiding this comment.
LGTM 📦
Thank you for taking your contribution and time 👏 👏 👏 👏
@mpetrunic tested locally and works as intended and its safe to be merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed:
I wanted an option to have the seed phrase hidden upon setup. I added a new boolean to allow this. The default remains as clicking the showSeedPhraseInput to make the seed visible while setting up metamask, so this is not a breaking change.
Discussion #83
Closes #85