Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

chore: merge unstable into master #179

Merged
merged 33 commits into from
Dec 15, 2022
Merged

chore: merge unstable into master #179

merged 33 commits into from
Dec 15, 2022

Conversation

mpetrunic
Copy link
Member

Short description of work done

PR Checklist

  • I have run linter locally
  • I have run unit and integration tests locally
    • Update configuration the newest version (readme and const)
  • Rebased to master branch / merged master

Changes

  • EXAMPLE - Removed basic auth from the controller

Issues

Closes #

mpetrunic and others added 14 commits September 22, 2022 15:47
@mpetrunic
chore: update CI for unstable branch
4de874a
@Mrtenz @mpetrunic
fix!: casing of MetaMask (#132)
00f9857 
Fix casing of MetaMask

Co-authored-by: Marin Petrunic <[email protected]>
@mpetrunic
fix: update ganache, fix test depending on goerli (#144)
d18efa4
@mpetrunic @BeroBurny
fix: selector issues, useless timeouts, reorganise tests (#145)
dc9b5fe 
* fix: update ganache, fix test depending on goerli

* fix: bugs in selectors, less timeout, reorganise structure

* update yarn

* chore: improve root hooks

* try to increase timeout

* better ci

* add screenshot uploading to ci

* fix screenshot name

* run screenshot on failed test

* fix lint

* change viewport

* fix tests

* fix#123124

* fix tests

* whyyyyyyyyyyyyyyyyyyyyyyyyy

* please

* fix testing dapp

* dunno anymore

* fix lint

* fix typo in selector

* update dapp loading

* refactor script fetching for `index.html`

* fix dam sing test

Co-authored-by: Bernard <[email protected]>
@mpetrunic
fix: import token flaky (#149)
c90db41 
fix: import-token flakyness
@mpetrunic @BeroBurny
feat!: update recommended metamask version (#151)
0c5dc17 
* feat!: update recommended metamask version

* implement screenshot helper

* implement hide portfolio popup action

* implement close what's new modal action

* remove obsolete test

* fix dappeteer methods broken on update

* chore: fix lint

* update metamask version to `10.20.0`

* fix addToken.ts

* address issues

* fix lint

* fix tests

* fix #4

* fix non visible buttons

Co-authored-by: Bernard Stojanović <[email protected]>
@mpetrunic
chore: change eslint config to chainsafe shared (#152)
9ab9b4c 
* chore: change eslint to chainsafe config

* address PR comments

* address PR comments

* fix tests
@mpetrunic
feat: add support for installing metamask flask (#153)
07775a7 
feat: add support for installing metamask flaask
@mpetrunic @BeroBurny
feat: ability to install snap (#154)
564aa4b 
* feat: add support for installing metamask flaask

* feat: ability to install snaps

* fi lint

* fix starting a snap

* fix snap install

Co-authored-by: Bernard <[email protected]>
@mpetrunic
fix: snap install faster, run all tests (#163)
d1a3ec4 
* fix: run all tests, faster check for installed snap

* fix condition bug
@Lykhoyda
feat: Add invokeSnap method; update installSnap method parameter; (#159)
e7d8435 
* Add invokeSnap method; update installSnap method parameter;

* adjust invokeSnap method after review

* Fix params type in invokeSnap method

* update invokeSnap Return type

* update invokeSnap with generic params

* update test expectation

* fix lint
@Lykhoyda @BeroBurny
feat: add ability to accept dialogs (#138) (#164)
2661323 
* feat:add ability to accept dialogs (#138)

* fix lint

* move installSnap, invokeSnap to dappeteer api; add bringToFront call to dialog methods

* pair improvements

* fix lint

* add methods snap

* exclude flask tests from global

* exclude flask tests from global

Co-authored-by: Bernard <[email protected]>
@mpetrunic
feat!: add playwright support (#167)
c25c66f 
* feat!: add playwright support

* fix: lint

* fix: ci matrix

* don't run snap tests on non flask

* address PR comments
@Lykhoyda @BeroBurny @mpetrunic
feat: added notification snap to methods-snap #137 (#166)
4804b88 
* pair improvements

* fix lint

* feat: add notify Snap method

* Added getAllNotifications method

* go back after getting all notifications

* remove timeout

* fix post merge errors

Co-authored-by: Bernard <[email protected]>
Co-authored-by: Marin Petrunic <[email protected]>
@mpetrunic mpetrunic marked this pull request as draft November 11, 2022 09:24
@mpetrunic
Copy link
Member Author

Will release manually from unstable as we have a couple of P0 issues that will create breaking changes as well.

@mpetrunic mpetrunic changed the title Merge unstable into master chore: merge unstable into master Nov 11, 2022
mpetrunic and others added 2 commits November 11, 2022 14:15
@mpetrunic
feat: method to bootstrap snap env (#180)
ba9745f 
* feat: install snap from local files

* fix: installing and invokeing snaps

* disable addToken test

* disable fail fast

* replace binance smart chain
@BeroBurny
chore: node engine requirements (#184)
b01e8d2 
set engines compatibility for 16 and above
@taylorjdawson
Copy link

@mpetrunic what's the timeline on the release?

@mpetrunic
Copy link
Member Author

@mpetrunic what's the timeline on the release?

You can already try it @chainsafe/[email protected] or @chainsafe/dappeteer@beta

mpetrunic and others added 5 commits November 15, 2022 14:21
@mpetrunic
fix: remove page param from install snap (#188)
a4c2031
@mpetrunic
feat!: replace outdated methods (#189)
4171ea4 
* feat!: replaced addTokenMethod

* feat: remove add network method
@Tbaut
chore: Ci enhancement (#193)
e382c4c 
* cache yarn and have lint and build as separate steps

* add back yarn.lock

* add jobs

* fix name
@Tbaut
feat: allow signing typed data (#191)
d63f9e4 
* add test to sign typed data

* add a check to see if the sign button is actually disabled

* clean up

* fix and clean

* remove flackyness

* lint

* fix playwright

* add hidden option for pupeteer types waitForSelector

* remove reload between tests
@mpetrunic
fix: fix prompt clicking flakiness, fix multiple snap key permissions (…
d9db933 
…#194)

* add retries when confirming prompts with lower timeout

* better snap error handling, ability to accept multiple key permissions

* bail on first fail

* add context to screenshots

* remove various random timeouts, add wait for overlay, more retrys

* fix lint

* increase timeout for loading network and token details

* address PR comments

* increase timeout

* add retry to profile dropdown
Lykhoyda and others added 10 commits November 28, 2022 14:53
@Lykhoyda @mpetrunic @BeroBurny
feat: snap notifications 137 (#187)
10c116e 
* chore: node engine requirements (#184) (#186)

set engines compatibility for 16 and above

Co-authored-by: Bernard Stojanović <[email protected]>

* pair improvements

* fix lint

* feat: add notify Snap method

* go back after getting all notifications

* remove timeout

* wip

* Add notification observe method

* update test

* remove unused code

* wip notifiction observer

* wip observer based notifications

* wip observer based notifications

* remove unused dependency

* cleanup

* fixes after merge

* revert method names

* clean waitForNotification method

* emitter solution - FP

* emitter solution - ClassBased

* Cleanup class based emitter

* fix lint

* fixes after merge

* remove p-event library

* remove eslint comment

* update test configuration

* return NotificationList from waitForNotification

* add getNotificationEmitter method

* remove back button

Co-authored-by: Marin Petrunić <[email protected]>
Co-authored-by: Bernard Stojanović <[email protected]>
Co-authored-by: Marin Petrunic <[email protected]>
@Tbaut
chore: Deprecate button clicks for tests (#195)
ef70dae 
* sharedConst and signature check

* without sharedConst :)

* request accounts

* request accounts

* long typed data

* short typed data

* add token reject/accept

* add network accept/reject

* actually verify the lock/unlock

* contract interactions

* address comment

* web3-utils 1.3.4

* addToken and addNetwork use boolean

* remove useless wait
@Tbaut @mpetrunic
chore: Update documentation and Readme (#202)
3ed2f18 
* docs

* change to metaMask accross the board and use bootstrap in our test

* MetaMMMMMMask

* snaps methods in API.md

* snaps usage in Readme.md

* Update README.md

Co-authored-by: Marin Petrunić <[email protected]>

* address comment

* add forgotten menu item for initSnapEnv

* removing jsdoc

Co-authored-by: Marin Petrunić <[email protected]>
@Tbaut @mpetrunic
chore: Remove local server for dapp (#203)
902b035 
* docs

* change to metaMask accross the board and use bootstrap in our test

* MetaMMMMMMask

* snaps methods in API.md

* snaps usage in Readme.md

* init

* lint

* add dev deps for ganache/console.log to make build pass

* Update README.md

Co-authored-by: Marin Petrunić <[email protected]>

* address comment

* add forgotten menu item for initSnapEnv

* removing jsdoc

Co-authored-by: Marin Petrunić <[email protected]>
@Tbaut
feat: Simplify installSnap and initSnapEnv apis (#206)
8574f4f 
* simplify api

* remove stray comments

* fix undefined opts

* double question mark back :)

* Update src/snap/utils.ts

* 2s for my use case

* test perf

* elegant race with bad name
@mpetrunic
chore: update web3 (#217)
270eafa 
chore: upgrade web3.js
@Lykhoyda
chore: update metamask version (#209)
20c42e5 
* update recommended version
@Lykhoyda
chore: fix timeout for accept dialog (#218)
6082a44 
increase timeout for accept and reject dialog
@Lykhoyda @BeroBurny
fix: increase viewport size (#219)
d5c1a80 
* Set viewport to most popular desktop resolution; fix for #208

Co-authored-by: Bernard Stojanović <[email protected]>
@Lykhoyda
fix: viewport typo (#220)
1b114a9 
fix viewport typo
@BeroBurny BeroBurny marked this pull request as ready for review December 15, 2022 10:14
BeroBurny
BeroBurny approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@BeroBurny BeroBurny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Lykhoyda
Lykhoyda approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@Lykhoyda Lykhoyda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me for releasing a new major version

@mpetrunic mpetrunic merged commit fed0b60 into master Dec 15, 2022
@Tbaut
Copy link
Contributor

Tbaut commented Dec 15, 2022

🚀

@github-actions github-actions bot mentioned this pull request Dec 15, 2022
Merged
mpetrunic added a commit that referenced this pull request Dec 15, 2022
@mpetrunic
Revert "chore: merge unstable into master (#179)"
562fceb 
This reverts commit fed0b60.
@mpetrunic mpetrunic mentioned this pull request Dec 15, 2022
Merged
mpetrunic added a commit that referenced this pull request Dec 15, 2022
@mpetrunic
revert: "chore: merge unstable into master" (#223)
9db6548 
Revert "chore: merge unstable into master (#179)"

This reverts commit fed0b60.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@irubido irubido irubido approved these changes

@Lykhoyda Lykhoyda Lykhoyda approved these changes

@BeroBurny BeroBurny BeroBurny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mpetrunic @taylorjdawson @Tbaut @BeroBurny @Lykhoyda @irubido @Mrtenz