Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weak subjectivity #579

Merged
merged 15 commits into from
Sep 22, 2021
Merged

Weak subjectivity #579

merged 15 commits into from
Sep 22, 2021

Conversation

BeroBurny
Copy link
Collaborator

@BeroBurny BeroBurny commented Aug 9, 2021 •
edited
Loading

Short description of work done

PR Checklist

  • I have run type check locally
  • I have run linter locally
  • I have run unit and integration tests locally
  • Rebased to master branch / merged master

Changes

Issues

Closes #576

@BeroBurny BeroBurny added the enhancement New feature or request label Aug 9, 2021
@BeroBurny BeroBurny requested a review from a team as a code owner August 9, 2021 06:52
@BeroBurny BeroBurny self-assigned this Aug 9, 2021
@BeroBurny BeroBurny requested review from morrigan and mpetrunic and removed request for a team August 9, 2021 06:52
@BeroBurny BeroBurny changed the base branch from master to develop August 9, 2021 06:52
@BeroBurny BeroBurny marked this pull request as draft August 9, 2021 06:52
@codecov
Copy link

codecov bot commented Aug 9, 2021 •
edited
Loading

Codecov Report

Merging #579 (03cc79e) into develop (c6eeab1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #579   +/-   ##
========================================
  Coverage    48.17%   48.17%           
========================================
  Files          117      117           
  Lines         2115     2115           
  Branches       231      231           
========================================
  Hits          1019     1019           
  Misses        1067     1067           
  Partials        29       29
Flag Coverage Δ
unit 48.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6eeab1...03cc79e. Read the comment docs.

@ChainSafe ChainSafe deleted a comment from lgtm-com bot Aug 9, 2021
@ChainSafe ChainSafe deleted a comment from lgtm-com bot Aug 9, 2021
mpetrunic
mpetrunic previously approved these changes Aug 9, 2021
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (develop@af0248b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #579   +/-   ##
==========================================
  Coverage           ?   48.02%           
==========================================
  Files              ?      117           
  Lines              ?     2124           
  Branches           ?      231           
==========================================
  Hits               ?     1020           
  Misses             ?     1075           
  Partials           ?       29
Flag Coverage Δ
unit 48.02% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af0248b...5b81270. Read the comment docs.

@BeroBurny BeroBurny marked this pull request as ready for review September 9, 2021 07:51
@BeroBurny BeroBurny requested a review from mpetrunic September 9, 2021 09:19
mpetrunic
mpetrunic reviewed Sep 20, 2021
View reviewed changes
.github/workflows/ci.yaml
@@ -30,7 +30,9 @@ jobs:
run: yarn run test:unit && yarn run test:components

- name: Run e2e tests
run: yarn run test:e2e
run: |
yarn add cheerio-select
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eh?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--frozen-lockfile dose not install cheerio-select even if is cheerio-select part of package.json

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it's in lockfile it must be installed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why, maybe you can figure it out?

src/renderer/ducks/beacon/sagas.ts Outdated Show resolved Hide resolved
@mpetrunic mpetrunic merged commit 7946b72 into develop Sep 22, 2021
@mpetrunic mpetrunic deleted the beroburny/weak-subjectivity-checkpoint branch September 22, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpetrunic mpetrunic mpetrunic approved these changes

@morrigan morrigan Awaiting requested review from morrigan

Assignees

@BeroBurny BeroBurny

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Start from Weak Subjectivity State
3 participants
@BeroBurny @codecov-commenter @mpetrunic