Fix atterstation effectivnes #493
Conversation
| payload.block === toHex(data.beaconBlockRoot) && | ||
| data.index === payload.index && | ||
| data.slot === payload.slot && | ||
| payload.bits === JSON.stringify(aggregationBits), |
There was a problem hiding this comment.
You need to check if bit on validator position in committee is set to true. I think you should also check source and target root.
There was a problem hiding this comment.
source and target contains epoch and root of slot as i check source slot in parent object of source and think checking for source and target can be bit a overkill and add unnecessary complexity
There was a problem hiding this comment.
it contains epoch and epoch boundary root (it's basically validator vote) that are unreleated to slot. That said since, you are checking committee index, it's highly unlikely that someone created attestation with different source and target outside of chainguardian (in that case more pressing issue is slashing anyways).
Codecov Report
@@ Coverage Diff @@
## master #493 +/- ##
=======================================
Coverage 56.98% 56.98%
=======================================
Files 73 73
Lines 1160 1160
Branches 135 135
=======================================
Hits 661 661
Misses 473 473
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
src/renderer/services/eth2/client/eth2ApiClient/cgEth2BeaconPoolApi.ts
Outdated
Show resolved
Hide resolved
BeroBurny
added
bug
closes #485