Handle glTFs with EXT_meshopt_compression #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilleyse
force-pushed
the
meshopt-support
branch
2 times, most recently
from
2b698b7
to
ccede74
Compare
lilleyse
force-pushed
the
meshopt-support
branch
from
ccede74
to
bffd4e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
glTFs with
EXT_meshopt_compressionare now handled correctly when going throughgltf-pipeline. The main fix was to support buffers that don't have a uri.This PR also fixes a bug where a malformed glb would be created when using draco compression with the uncompressed fallback with embedded resources.
forceMergeBuffersforces glb's to merge all buffers into one. The same problem showed up for meshopt models with thefallback: trueoption.There was also a minor issue where the name of the merged buffer was the name of the last buffer in
gltf.buffersrather than the first. The first buffer usually has the main contents, especially when loaded from a glb.