Change ceil back to round #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this be easily unit tested? Since we are publishing libraries now and this is going on the website, it would be nice to add tests for problems as we find them. |
|
Added a test. In the future, we will want some sort of automated testing system that converts sample models to catch stuff like this. |
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lilleyse, we changed this before to make sure that rounding for integers went up for models with JOINT semantics. That is no longer an issue.
Currently if you run 2CylinderEngine through the pipeline with quantization, it tries to write 65536 to a uint16 buffer and crashes. This is because of a very minor floating point error that is solved by rounding instead.