Merge pull request #286 from shehzan10/leading-underscore-fix

Add regex to remove leading underscore from shader identifiers
CesiumGS · May 30, 2017 · 6a8239e · 6a8239e
2 parents 3449df8 + d812a19
commit 6a8239e
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/lib/processModelMaterialsCommon.js b/lib/processModelMaterialsCommon.js
@@ -812,7 +812,9 @@ function ensureSemanticExistenceForPrimitive(gltf, primitive) {
                 var accessorId = attributes[semantic];
                 var accessor = accessors[accessorId];
                 var lowerCase = semantic.toLowerCase();
+                lowerCase = lowerCase.replace(/^_*/g, '');  // Remove all starting _ from name. GLSL does not allow __ double underscores
                 var attributeName = 'a_' + lowerCase;
+
                 technique.parameters[lowerCase] = {
                     semantic: semantic,
                     type: accessor.componentType