Extend far plane slightly to prevent clipping #9139
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9114
#8850 made it so that the far plane only goes as far as the farthest object visible to the camera. The problem was geometry right on the far plane might get clipped at certain camera angles. This was somewhat hardware dependent since the problem didn't happen on my 2015 Macbook but happened on mostly everything else.
The fix was to extend the far plane a bit further than the farthest object:
Here's a debug view showing the problem. The ground primitive's bounding volume lines up almost perfectly with the frustum which causes clipping.
Sandcastle for testing