Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

primitive can be used to per-feature postprocess #9131

Closed
wants to merge 3 commits into from

Conversation

lafflan
Copy link

@lafflan lafflan commented Sep 3, 2020

before this, set primitive selected in the per-feature postprocess had no effect, because they can't get the primitive's pickIds.
add a readonly property to insure primitive can be used to per-feature postprocess

before this, set primitive selected in the per-feature postprocess had no effect, because they can't get the primitive's pickId or pickIds.
add a readonly property to insure primitive can be used to per-feature postprocess
@cesium-concierge
Copy link

Thank you so much for the pull request @sweerwen! I noticed this is your first pull request and I wanted to say welcome to the Cesium community!

The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.

  • ❌ Missing CONTRIBUTORS.md entry.
  • ❌ Missing CLA.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@lafflan
Copy link
Author

lafflan commented Sep 3, 2020

#7984 (comment)

@cesium-concierge
Copy link

Thanks again for your contribution @sweerwen!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

@lafflan lafflan closed this Oct 9, 2020
@lafflan lafflan deleted the patch-2 branch October 23, 2020 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants