New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No array.fill in ie #8188

Merged

mramato merged 1 commit into master from fix-ie

Sep 20, 2019

Contributor

hpinkos commented Sep 19, 2019

The cutout ellipsoid PR broke IE because IE doesn't support array.fill. I changed these to use fillArray instead.

Also added the 'Beginner' label to the labels sandcastle example.


          no array.fill in ie

a5f6989

hpinkos added the priority - next release label

cesium-concierge commented Sep 19, 2019

Thanks for the pull request @hpinkos!

✔️ Signed CLA found.
❔ CHANGES.md was not updated.
- If this change updates the public API in any way, please add a bullet point to CHANGES.md.
❔ Unit tests were not updated.
- Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

Cesium Viewer works.
Works in 2D/CV.
Works (or fails gracefully) in IE11.

likangning93 mentioned this pull request

Fix wall segments for tiny extruded geometry #8177

Merged

mramato merged commit d58cd99 into master

mramato deleted the fix-ie branch

September 20, 2019 14:01

likangning93 mentioned this pull request

Render globe tiles if any layer is loaded #8028

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority - next release