Fix 8074

[loshjawrence]

An example fix for #8074.

Right now there are .show s on individual primitives but there's also the scene's primitives.show.

This fix treats the scene's primitive.show like a master switch and would be the simplest fix for this.

localhost sandcastle

[cesium-concierge]

Thanks for the pull request @loshjawrence!

• ✔️ Signed CLA found.
• ❔ CHANGES.md was not updated.
  • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
• ❔ Unit tests were not updated.
  • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

• Cesium Viewer works.
• Works in 2D/CV.
• Works (or fails gracefully) in IE11.

[mramato]

This fix treats the scene's primitive.show like a master switch and would be the simplest fix for this.

Treating it like a master switch instead of having it toggle off the individual primitives is what we do elsewhere. So I assume that means this is the "right" fix?

[mramato]

@OmarShehata can you confirm everything is good on your end?

@lilleyse will you have time to look at this soon?

[OmarShehata]

I can confirm this fixes the original issue, but you can still get this effect to happen by using tileset.show instead of scene.primitives.show. See this localhost Sandcastle as brought up here #8074 (comment).

[loshjawrence]

@OmarShehata I added @dennisadams other fix for this

[mramato]

Where are we at here. @OmarShehata please merge if this is ready so it can sit in master before the release to make sure it fully fixes the problem. CC @lilleyse any thoughts

[lilleyse]

Looks fine to me.

[mramato]

@OmarShehata please merge once you confirm the issue you could still reproduced is fixed. Thanks!

[OmarShehata]

Works great, thanks @loshjawrence !