Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imagery Provider Resource Fix #8079

Merged
merged 3 commits into from
Aug 16, 2019

Conversation

ProjectBarks
Copy link
Contributor

This solves an issue where createOpenStreetMapImageryProvider would improperly handle a Resource object.

I also fixed up MapboxImageryProvider to work in a more standardized and expected way.

This is related to #4812

@cesium-concierge
Copy link

Thanks for the pull request @ProjectBarks!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@mramato
Copy link
Contributor

mramato commented Aug 16, 2019

Looks like you have some test failures

@ProjectBarks
Copy link
Contributor Author

@mramato Good catch. Submitted relevant changes.

@mramato
Copy link
Contributor

mramato commented Aug 16, 2019

Thanks!

@mramato mramato merged commit 36e95c6 into CesiumGS:master Aug 16, 2019
@ProjectBarks ProjectBarks deleted the imagery-provider-resource-fix branch August 16, 2019 14:02
@thw0rted
Copy link
Contributor

thw0rted commented Sep 4, 2019

I know this is already merged, but the current changes forgot to update the relevant documentation. Is it all generated from the JSDoc blocks?

@OmarShehata
Copy link
Contributor

@thw0rted the docs are indeed generated from the JSDoc blocks. You can run npm run generateDocumentation to see the docs locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants