New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing Cesium GS contributors #8039

Merged

OmarShehata merged 1 commit into master from missing-contrib

Aug 6, 2019

Contributor

OmarShehata commented Aug 5, 2019

Adding in missing contributors.md entries for everyone who has contributed to CesiumJS under Cesium GS since the spin out.


          Add missing Cesium GS contributors

7d1ce7c

cesium-concierge commented Aug 5, 2019

Thanks for the pull request @OmarShehata!

✔️ Signed CLA found.
❔ CHANGES.md was not updated.
- If this change updates the public API in any way, please add a bullet point to CHANGES.md.
❔ Unit tests were not updated.
- Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

Cesium Viewer works.
Works in 2D/CV.
Works (or fails gracefully) in IE11.

OmarShehata merged commit 8e19a19 into master

OmarShehata deleted the missing-contrib branch

August 6, 2019 12:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet