Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eslint configuration updates and fixes #7809

Merged
merged 1 commit into from
May 3, 2019
Merged

eslint configuration updates and fixes #7809

merged 1 commit into from
May 3, 2019

Conversation

mramato
Copy link
Contributor

@mramato mramato commented May 3, 2019

  • Update Node ecmaVersion to '2019'.
  • Enable no-tabs.
  • Enabled no-restricted-globals for jasmine fit and fdescribe.
  • Remove existing tabs from code-base.
  • Update eslint-config-cesium CHANGES and version

Closes #7785

@mramato
eslint configuration updates and fixes
8034629 
* Update Node ecmaVersion to '2019'.
* Enable [no-tabs](https://eslint.org/docs/rules/no-tabs).
* Enabled [no-restricted-globals](https://eslint.org/docs/rules/no-restricted-globals) for jasmine `fit` and `fdescribe`.
* Remove existing tabs from code-base.
* Update eslint-config-cesium CHANGES and version

Closes #7785
@cesium-concierge
Copy link

Thanks for the pull request @mramato!

  • ✔️ Signed CLA found.
  • ❔ CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@mramato mramato mentioned this pull request May 3, 2019
Merged
@mramato mramato requested a review from hpinkos May 3, 2019 15:46
@hpinkos
Copy link
Contributor

hpinkos commented May 3, 2019

👍 thanks @mramato!

@hpinkos hpinkos merged commit a35f010 into master May 3, 2019
@hpinkos hpinkos deleted the eslint-updates branch May 3, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hpinkos hpinkos Awaiting requested review from hpinkos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable no-tabs rule in es-lint
3 participants
@mramato @cesium-concierge @hpinkos