Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect Cesium from crashing when the camera goes through terrain #7667

Merged
merged 3 commits into from
Mar 29, 2019

Conversation

emackey
Copy link
Contributor

@emackey emackey commented Mar 20, 2019

This fixes #6783, at least for the exact error shown in the first stack trace posted on that issue.

I found an (internal) CZML that was reproducing that quite reliably, and was able to do some testing to come up with this fix.

@cesium-concierge
Copy link

Thanks for the pull request @emackey!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@emackey emackey requested a review from bagnell March 25, 2019 18:10
@lilleyse
Copy link
Contributor

I can't seem to reproduce the crash in master right now, but the fix looks good.

@lilleyse lilleyse merged commit f8604e9 into master Mar 29, 2019
@lilleyse lilleyse deleted the camera-crashes branch March 29, 2019 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving the camera eventually crashes (if you're unlucky).
3 participants