Added examples in Matrix4.js for #651 #724
Conversation
| @@ -796,6 +796,17 @@ define([ | |||
| * @return {Array} The modified Array parameter or a new Array instance if one was not provided. | |||
| * | |||
| * @exception {DeveloperError} matrix is required. | |||
| * | |||
| * @example | |||
| * //converts a matrix of order 4 to an array | |||
There was a problem hiding this comment.
These examples look good. Thanks @nobelium.
Can we just do a minor wording tweak to make them a bit more friendly to non-math folks by changing "matrix of order 4" to "Matrix4" or "4x4 matrix?"
|
@pjcozzi I have rephrased those lines and added some more examples. |
| * var a = Matrix4.toArray(m); | ||
| * | ||
| * // m remains the same | ||
| * //creates a = [10.0, 11.0, 12.0, 13.0, 14.0, 15.0, 16.0, 17.0, 18.0, 19.0, 20.0, 21.0, 22.0, 23.0, 24.0, 25.0] |
There was a problem hiding this comment.
Did you test this in the debugger? This shows a row-major ordering, but I believe it should be column-major.
|
Thanks @nobelium. Just had those few comments. |
|
@pjcozzi Sorry, my bad. I have corrected the mistakes.. |
|
Thanks @nobelium |
Added examples in Matrix4.js for #651
|
Just an FYI this change introduced a bunch of line-ending and trailing whitespace issues reported by jsHint. (fixed in 2e9cbe7) @nobelium It's always a good idea to run Thanks again for the changes. I only mention this so that your future pull requests go smoothly. |
|
Thanks, I did not know that trailing whitespace would create an issue. |
|
There's only a few cases where it can lead to a genuine problem, such as multiline strings. For the most part it's about keeping the code clean and consistent. Extra space and differing line breaks make diffing and maintencence a lot harder. Thanks again for the changes. |
Added examples for
Matrix4.toArray
Matrix4.getColumn
Matrix4.setColumn
Matrix4.getRow
Matrix4.setRow
Matrix4.negate
Matrix4.transpose