Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unexpected json response from bing api #6071

Merged
merged 1 commit into from
Jan 3, 2018
Merged

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Dec 25, 2017

data.resourceSets may be an empty array if something happens unexpectedly (for example, hitting a rate limit)

@cesium-concierge
Copy link

Signed CLA is on file.

@hpinkos, thanks for the pull request! Maintainers, we have a signed CLA from @hpinkos, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@hpinkos hpinkos requested a review from pjcozzi January 2, 2018 16:28
@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 2, 2018

@tfili do you want to review this?

@tfili
Copy link
Contributor

tfili commented Jan 3, 2018

Looks good. The API doc leads me to believe that there can't be more than one resourceSet, so this is ok.

@tfili tfili merged commit 7f9abdd into master Jan 3, 2018
@tfili tfili deleted the bing-metadata branch January 3, 2018 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants