Fix Firefox console warnings. #5939
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,25 @@ | ||
| define([ | ||
| '../Core/Check', | ||
| '../Core/defaultValue', | ||
| '../Core/defined', | ||
| '../Core/defineProperties', | ||
| '../Core/DeveloperError', | ||
| '../Core/PixelFormat', | ||
| './PixelDatatype' | ||
| ], function( | ||
| Check, | ||
| defaultValue, | ||
| defined, | ||
| defineProperties, | ||
| DeveloperError, | ||
| PixelFormat, | ||
| PixelDatatype) { | ||
| 'use strict'; | ||
|
|
||
| /** | ||
| * @private | ||
| */ | ||
| function CubeMapFace(gl, texture, textureTarget, targetFace, pixelFormat, pixelDatatype, size, preMultiplyAlpha, flipY, initialized) { | ||
| this._gl = gl; | ||
| this._texture = texture; | ||
| this._textureTarget = textureTarget; | ||
|
|
@@ -25,6 +29,7 @@ define([ | |
| this._size = size; | ||
| this._preMultiplyAlpha = preMultiplyAlpha; | ||
| this._flipY = flipY; | ||
| this._initialized = initialized; | ||
| } | ||
|
|
||
| defineProperties(CubeMapFace.prototype, { | ||
|
|
@@ -91,15 +96,52 @@ define([ | |
| var target = this._textureTarget; | ||
|
|
||
| // TODO: gl.pixelStorei(gl._UNPACK_ALIGNMENT, 4); | ||
|
|
||
| gl.activeTexture(gl.TEXTURE0); | ||
| gl.bindTexture(target, this._texture); | ||
|
|
||
| var uploaded = false; | ||
|
There was a problem hiding this comment. Here and below seems more complicated than it needs to be; I will not have the time to dive deep for awhile. @lilleyse can you take a look? |
||
| if (!this._initialized) { | ||
| if (xOffset === 0 && yOffset === 0 && source.width === this._size && source.height === this._size) { | ||
| // initialize the entire texture | ||
| if (defined(source.arrayBufferView)) { | ||
| gl.pixelStorei(gl.UNPACK_PREMULTIPLY_ALPHA_WEBGL, false); | ||
| gl.pixelStorei(gl.UNPACK_FLIP_Y_WEBGL, false); | ||
|
|
||
| gl.texImage2D(this._targetFace, 0, this._pixelFormat, this._size, this._size, 0, this._pixelFormat, this._pixelDatatype, source.arrayBufferView); | ||
| } else { | ||
| // Only valid for DOM-Element uploads | ||
| gl.pixelStorei(gl.UNPACK_PREMULTIPLY_ALPHA_WEBGL, this._preMultiplyAlpha); | ||
| gl.pixelStorei(gl.UNPACK_FLIP_Y_WEBGL, this._flipY); | ||
|
|
||
| gl.texImage2D(this._targetFace, 0, this._pixelFormat, this._pixelFormat, this._pixelDatatype, source); | ||
| } | ||
| uploaded = true; | ||
| } else { | ||
| gl.pixelStorei(gl.UNPACK_PREMULTIPLY_ALPHA_WEBGL, false); | ||
| gl.pixelStorei(gl.UNPACK_FLIP_Y_WEBGL, false); | ||
|
|
||
| // initialize the entire texture to zero | ||
| var bufferView = PixelFormat.createTypedArray(this._pixelFormat, this._pixelDatatype, this._size, this._size); | ||
| gl.texImage2D(this._targetFace, 0, this._pixelFormat, this._size, this._size, 0, this._pixelFormat, this._pixelDatatype, bufferView); | ||
| } | ||
| this._initialized = true; | ||
| } | ||
|
|
||
| if (!uploaded) { | ||
| if (source.arrayBufferView) { | ||
| gl.pixelStorei(gl.UNPACK_PREMULTIPLY_ALPHA_WEBGL, false); | ||
| gl.pixelStorei(gl.UNPACK_FLIP_Y_WEBGL, false); | ||
|
|
||
| gl.texSubImage2D(this._targetFace, 0, xOffset, yOffset, source.width, source.height, this._pixelFormat, this._pixelDatatype, source.arrayBufferView); | ||
| } else { | ||
| // Only valid for DOM-Element uploads | ||
| gl.pixelStorei(gl.UNPACK_PREMULTIPLY_ALPHA_WEBGL, this._preMultiplyAlpha); | ||
| gl.pixelStorei(gl.UNPACK_FLIP_Y_WEBGL, this._flipY); | ||
|
|
||
| // Source: ImageData, HTMLImageElement, HTMLCanvasElement, or HTMLVideoElement | ||
| gl.texSubImage2D(this._targetFace, 0, xOffset, yOffset, this._pixelFormat, this._pixelDatatype, source); | ||
| } | ||
| } | ||
|
|
||
| gl.bindTexture(target, null); | ||
|
|
@@ -160,6 +202,7 @@ define([ | |
| gl.bindTexture(target, this._texture); | ||
| gl.copyTexSubImage2D(this._targetFace, 0, xOffset, yOffset, framebufferXOffset, framebufferYOffset, width, height); | ||
| gl.bindTexture(target, null); | ||
| this._initialized = true; | ||
| }; | ||
|
|
||
| return CubeMapFace; | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to leave this TODO in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that was in the original code. I just moved it.