Adds normalShading option to the repo #5433

AnimatedRNG · 2017-06-07T16:01:10Z

Part of #5152

lilleyse · 2017-06-08T13:41:05Z

Source/Scene/PointCloud3DTileContent.js

        var vertexArray = content._drawCommand.vertexArray;

+        var normalsEnabled = hasNormals && normalShading;


I actually think this boolean may not be the right approach. We still want backFaceCulling to work even if normalShading is false.

Are you referring to the part around line 1022 (https://github.com/AnimatedRNG/cesium/blob/eb7b76ece10dd4422a9377b94df8ac725c97b730/Source/Scene/PointCloud3DTileContent.js#L1022)?

Updated with a new fix for this case

backFaceCulling will have issues because all the normal attribute setup is still behind the normalsEnabled boolean. Ultimately normalsEnabled should probably be removed.

So that entire function should just ignore normalShading?

Yeah, except for the part that actually does normal shading.

Another approach is to continue to use normalsEnabled but set it equal to normalShading || backFaceCulling.

I made those edits, although I'm don't totally understand the relationship between backface culling and normal shading in that function

backFaceCulling and normalShading are independent of each other but both require normals. So normalsEnabled should be true if hasNormals is true and at least one of the options is true. When appending the back face culling code it will need to check normalsEnabled && backFaceCulling and when appending the normal shading code it will need to check normalsEnabled && normalShading.

The original idea I had was to keep most of the code as is and just wrap the normal shading code with hasNormals && normalShading.

lilleyse · 2017-06-08T13:44:55Z

Also be sure to write a test for this. It can be something like rendering with normalShading, then rendering with normalsShading off, then checking that the colors are different.

See rebuilds shader style when expression changes for a partway example.

lilleyse · 2017-06-08T13:51:41Z

Other than those comments, looks great! I tested that it works in Sandcastle.

AnimatedRNG · 2017-06-08T14:54:30Z

Updated with a new test

pjcozzi · 2017-07-21T13:28:54Z

What's the plan here? Do we still plan to do this in light of #5455?

lilleyse

It's still a good idea to finish this up - these are my last comments here.

lilleyse · 2017-07-21T13:38:55Z

Source/Scene/PointCloud3DTileContent.js

        var vertexArray = content._drawCommand.vertexArray;

+        var normalsEnabled = (hasNormals && normalShading) || backFaceCulling;


This should be:

var normalsEnabled = hasNormals && (normalShading || backFaceCulling);

lilleyse · 2017-07-21T13:39:23Z

Source/Scene/PointCloud3DTileContent.js

@@ -1002,7 +1009,7 @@ define([

        vs += '    color = color * u_highlightColor; \n';

-        if (hasNormals) {
+        if (normalsEnabled) {


Should be normalsEnabled && normalShading

lilleyse · 2017-07-21T13:39:52Z

Source/Scene/PointCloud3DTileContent.js

@@ -1012,7 +1019,7 @@ define([
        vs += '    v_color = color; \n' +
              '    gl_Position = czm_modelViewProjection * vec4(position, 1.0); \n';

-        if (hasNormals && backFaceCulling) {
+        if (normalsEnabled) {


Should be normalsEnabled && backFaceCulling.

lilleyse · 2017-11-07T14:49:20Z

I made some final adjustments here. @ggetz would you like to review?

ggetz · 2017-11-08T14:44:51Z

@lilleyse Looks good to me

pjcozzi · 2017-11-08T21:35:54Z

Quick out of touch question: since PointCloud3DTileContent is private, when and how is this used?

lilleyse · 2017-11-08T22:08:11Z

Right now it's not used, unless someone knows what they're doing. It's like the backFaceCulling option which is also only in this file.

I don't think we ever concluded if these should be properties of the tileset, or the style, or just in the styling language.

pjcozzi · 2017-11-08T22:13:20Z

So are we sure we want to merge this? Seems like no.

hpinkos · 2018-01-11T17:10:26Z

@lilleyse Are we planning to merge this at some point or should we close this?

lilleyse · 2018-01-11T17:27:06Z

Personally I don't think there's any harm in merging this since it doesn't preclude a future PR, and everything in here is @private.

I also don't care that strongly if it's closed either.

hpinkos · 2018-01-11T17:36:32Z

Is this something that is going to be useful or is it not going to be used? If it doesn't add any particular value we should probably just close it.

lilleyse · 2018-01-11T18:40:57Z

It's minor enough to close.

Adds normalShading option to the repo

eb7b76e

lilleyse reviewed Jun 8, 2017

View reviewed changes

Adds test for changing normal shading settings

62c6e54

AnimatedRNG added 2 commits June 8, 2017 11:37

backFaceCulling no longer depends on normalShading

106436c

normalShading should hopefully not break backFaceCulling now

b6355d9

pjcozzi mentioned this pull request Jun 14, 2017

Options to turn off normal shading for point clouds #5152

Closed

mramato changed the base branch from 3d-tiles to master June 19, 2017 17:11

lilleyse reviewed Jul 21, 2017

View reviewed changes

lilleyse added 2 commits October 27, 2017 14:37

Adjustments

e6f6de1

Merge branch 'master' into 3d-tiles-normals-options

356b09c

lilleyse closed this Jan 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds normalShading option to the repo #5433

Adds normalShading option to the repo #5433

AnimatedRNG commented Jun 7, 2017

lilleyse Jun 8, 2017

AnimatedRNG Jun 8, 2017

lilleyse Jun 8, 2017

AnimatedRNG Jun 8, 2017

lilleyse Jun 8, 2017

AnimatedRNG Jun 8, 2017 •

edited

Loading

lilleyse Jun 8, 2017

AnimatedRNG Jun 9, 2017

lilleyse Jun 9, 2017

lilleyse commented Jun 8, 2017

lilleyse commented Jun 8, 2017

AnimatedRNG commented Jun 8, 2017

pjcozzi commented Jul 21, 2017

lilleyse left a comment •

edited

Loading

lilleyse Jul 21, 2017

lilleyse Jul 21, 2017

lilleyse Jul 21, 2017

lilleyse commented Nov 7, 2017

ggetz commented Nov 8, 2017

pjcozzi commented Nov 8, 2017

lilleyse commented Nov 8, 2017

pjcozzi commented Nov 8, 2017

hpinkos commented Jan 11, 2018

lilleyse commented Jan 11, 2018

hpinkos commented Jan 11, 2018

lilleyse commented Jan 11, 2018

		var vertexArray = content._drawCommand.vertexArray;

		var normalsEnabled = hasNormals && normalShading;

		var vertexArray = content._drawCommand.vertexArray;

		var normalsEnabled = (hasNormals && normalShading) \|\| backFaceCulling;

Adds normalShading option to the repo #5433

Adds normalShading option to the repo #5433

Conversation

AnimatedRNG commented Jun 7, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AnimatedRNG Jun 8, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lilleyse commented Jun 8, 2017

lilleyse commented Jun 8, 2017

AnimatedRNG commented Jun 8, 2017

pjcozzi commented Jul 21, 2017

lilleyse left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lilleyse commented Nov 7, 2017

ggetz commented Nov 8, 2017

pjcozzi commented Nov 8, 2017

lilleyse commented Nov 8, 2017

pjcozzi commented Nov 8, 2017

hpinkos commented Jan 11, 2018

lilleyse commented Jan 11, 2018

hpinkos commented Jan 11, 2018

lilleyse commented Jan 11, 2018

AnimatedRNG Jun 8, 2017 •

edited

Loading

lilleyse left a comment •

edited

Loading