Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tile continually expiring when expireDate is set #5428

Merged
merged 4 commits into from
Jun 7, 2017

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Jun 6, 2017

For some reason I had not tested setting just expireDate without expireDuration.

This fix prevents the tile from thinking it is expired every frame.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jun 6, 2017

CI has a test failure:

1) tile expires
     Scene/Cesium3DTileset
     Expected false to be true.
    at Specs/Scene/Cesium3DTilesetSpec.js:2600:50
    at Promise.then (Source/ThirdParty/when.js:196:34)
    at Source/ThirdParty/when.js:297:13
    at processQueue (Source/ThirdParty/when.js:647:4)
    at _resolve (Source/ThirdParty/when.js:333:4)

https://travis-ci.org/AnalyticalGraphicsInc/cesium/builds/239785849?utm_source=github_status&utm_medium=notification

@lilleyse
Copy link
Contributor Author

lilleyse commented Jun 7, 2017

That fix wasn't adding the timestamp to the url - this should do it now.

@pjcozzi pjcozzi merged commit 60d426e into 3d-tiles Jun 7, 2017
@pjcozzi pjcozzi deleted the expire-date-fix branch June 7, 2017 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants