Fix rotatable 2D crash #4992
Merged
Fix rotatable 2D crash #4992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update CHANGES.md. Are you sure we don't want a smaller epsilon since this is 64-bit floating point? |
Ah, OK. |
|
Looks good crashes in 1.30, but not this branch. I'll update CHANGES.md. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4619. Floating point error was causing the maximum far plane of the frustum to be greater than the far plane of the farthest frustum in the multi-frustum by 1e-10. Added an epsilon check to stop possibility of infinite recursion.