When the texture is not rotated, the rendering fails #4535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mramato
reviewed
Oct 31, 2016
| @@ -802,6 +802,7 @@ define([ | |||
| options.textureMatrix = textureMatrix; | |||
| options.tangentRotationMatrix = tangentRotationMatrix; | |||
| options.size = options.width * options.height; | |||
| options.stRotation = stRotation; | |||
There was a problem hiding this comment.
Is this actually used anywhere? I traced through the code visually and didn't see this particular options object including stRotation.
There was a problem hiding this comment.
Yes, it's used to make a textureMatrix that rotates the st coordinates
There was a problem hiding this comment.
Sorry to be dense, but where is that happening? From what I can tell, only constructRectangle and constructExtrudedRectangle get called with this specific options object and neither of them use it.
There was a problem hiding this comment.
Nevermind, I see it now. Sorry for the noise.
|
@hpinkos I've always been told that the squeaky wheel gets the grease... here is my weekly squeak for this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combine the patch that @dwhipps suggested to fix the bug #2737 and #4515