Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derived commands #3806

Merged
merged 8 commits into from
Apr 6, 2016
Merged

Derived commands #3806

merged 8 commits into from
Apr 6, 2016

Conversation

bagnell
Copy link
Contributor

@bagnell bagnell commented Apr 5, 2016

Adds derived commands for 3d tiles, shadows, and OIT.

pjcozzi
pjcozzi reviewed Apr 5, 2016
View reviewed changes
Source/Renderer/DrawCommand.js
this._debugOverlappingFrustums = 0;
this._dirty = true;

// TODO: how to invalidate this? Get/set for properties above? Make some of them (e.g., vertex array) readonly?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this TODO? It has the same idea we discussed today.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are we going to release the resources for the command? Primitives release the resources for each command, but who releases the resources for derived commands?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command can own the derived commands. In some cases - like in 3D Tiles - they will not have new resources.

@pjcozzi
Copy link
Contributor

pjcozzi commented Apr 5, 2016

What's the deal with the Scene/TileBoundingBox test failures in CI: https://travis-ci.org/AnalyticalGraphicsInc/cesium/builds/120984476

@pjcozzi
Copy link
Contributor

pjcozzi commented Apr 5, 2016

Just those minor comments. What is the best branch strategy here? Merge this into master, then master into shadows and 3d-tiles, then additional derived commands PRs into shadows and 3d-tiles?

@bagnell
Copy link
Contributor Author

bagnell commented Apr 6, 2016

What's the deal with the Scene/TileBoundingBox test failures in CI

I'm not sure. The tests pass when run locally.

@bagnell
Copy link
Contributor Author

bagnell commented Apr 6, 2016

Just those minor comments. What is the best branch strategy here? Merge this into master, then master into shadows and 3d-tiles, then additional derived commands PRs into shadows and 3d-tiles?

Yes, that was my plan.

@bagnell
Copy link
Contributor Author

bagnell commented Apr 6, 2016

@pjcozzi This is ready for another look. The failing tests were fixed in #3811.

@pjcozzi pjcozzi merged commit f969382 into master Apr 6, 2016
@pjcozzi pjcozzi deleted the derived-commands branch April 6, 2016 19:15
@pjcozzi pjcozzi mentioned this pull request Apr 12, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bagnell @pjcozzi