Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sun uniform #3157

Merged
merged 2 commits into from
Nov 3, 2015
Merged

Fix sun uniform #3157

merged 2 commits into from
Nov 3, 2015

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Nov 2, 2015

For #3141

@pjcozzi
Copy link
Contributor

pjcozzi commented Nov 2, 2015

Good catch. Update CHANGES.md and include a link to #3141. We'll ship this with 1.16.

@lilleyse
Copy link
Contributor Author

lilleyse commented Nov 2, 2015

Updated CHANGES.md

@mramato
Copy link
Contributor

mramato commented Nov 3, 2015

I can confirm that this fixes the issue. I was talking to @lilleyse offline as to why this ever worked on any system to begin with, and we think that correct implementations end up giving the uniforms default values, where as my phone's driver does not. (this is just conjecture though).

The end result is that this change affects the desktop as well, as you can see from the below screenshots and the end result is more correct visualization on all devices.

master:
image

this branch:
image

mramato added a commit that referenced this pull request Nov 3, 2015
@mramato mramato merged commit b463655 into CesiumGS:master Nov 3, 2015
@mramato
Copy link
Contributor

mramato commented Nov 3, 2015

Thanks @lilleyse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants