Fix material caching for canvases #2843
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cesium would incorrectly use an HTMLCanvasElement as the key to the Material texture cache dictionary. This means that if you had multiple canvas-based materials, we would only ever use the first one that was added (because the cache lookup would always succeed even if the canvases were difference). This change uses toDataURL to store canvas elements in the cache. This is sub-optimal since toDataURL is slow and also creates huge string, but the best we can do in the short term. We need a good overlal long term strategy for dealing with canvases, but that's outside the scope of this PR.
|
Superseded by #2850 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cesium would incorrectly use an HTMLCanvasElement as the key to the Material texture cache dictionary. This means that if you had multiple canvas-based materials, we would only ever use the first one that was added (because the cache lookup would always succeed even if the canvases were difference).
This change uses toDataURL to store canvas elements in the cache. This is sub-optimal since toDataURL is slow and also creates huge string, but the best we can do in the short term. We need a good overlal long term strategy for dealing with canvases, but that's outside the scope of this PR.
Fixes #2821