-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Events #2440
Conversation
…entHandler to listen on the document for pointer up and move events.
To further clarify, it's my believe that we provide little to no benefit by providing our own API for this kind of stuff and we should encourage users to use the standard HTML events wherever possible. We should seriously consider deprecating the public API we expose for these events with the next release and switching any Sandcastle examples over to use native events. |
I reverted the remaining changes, but I left the updated tests. |
+1. Can you write an issue with the specifics to deprecate? |
Code looks good, test pass, and the problems I originally found in National Map go away with this change. Are there Sandcastle changes that need to happen too? That can be a separate pull request in any case. Merging. |
This reverts the changes in #2408 and #2417. It instead adds an option to listen for the mouse/pointer/touch up and move events on the document. Fixes #2435.