Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events #2440

Merged
merged 3 commits into from
Jan 29, 2015
Merged

Events #2440

merged 3 commits into from
Jan 29, 2015

Conversation

bagnell
Copy link
Contributor

@bagnell bagnell commented Jan 29, 2015

This reverts the changes in #2408 and #2417. It instead adds an option to listen for the mouse/pointer/touch up and move events on the document. Fixes #2435.

…entHandler to listen on the document for pointer up and move events.
@mramato
Copy link
Contributor

mramato commented Jan 29, 2015

@emackey (and @kring) can you guys take point on reviewing/merging this? Thanks.

@emackey
Copy link
Contributor

emackey commented Jan 29, 2015

After discussion with @bagnell and @mramato, we are going to completely back out #2408 and #2417, and just have the picking examples that needed these changes use native JS events instead of Cesium events.

@mramato
Copy link
Contributor

mramato commented Jan 29, 2015

To further clarify, it's my believe that we provide little to no benefit by providing our own API for this kind of stuff and we should encourage users to use the standard HTML events wherever possible. We should seriously consider deprecating the public API we expose for these events with the next release and switching any Sandcastle examples over to use native events.

@bagnell
Copy link
Contributor Author

bagnell commented Jan 29, 2015

I reverted the remaining changes, but I left the updated tests.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 29, 2015

To further clarify, it's my believe that we provide little to no benefit by providing our own API for this kind of stuff and we should encourage users to use the standard HTML events wherever possible. We should seriously consider deprecating the public API we expose for these events with the next release and switching any Sandcastle examples over to use native events.

+1. Can you write an issue with the specifics to deprecate?

@kring
Copy link
Member

kring commented Jan 29, 2015

Code looks good, test pass, and the problems I originally found in National Map go away with this change. Are there Sandcastle changes that need to happen too? That can be a separate pull request in any case. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cesium prevents sliders from working
5 participants