TileMapServiceImageryProvider can now handle casing differences in XML documents #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Andre-Nunes this looks good to me. Mind adding some tests and updating |
|
And thanks for doing this! |
|
No problem, about updating |
|
Yep, put it in the b25 section. It's not a breaking change, of course. |
|
I think it is done. |
|
Looks good, thanks @Andre-Nunes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves issue #1299
Instead of using
getElementsByTagNameI'm iterating the nodes in the document and checking them with a case-insensitive regular expression.Please review it and tell me if there's a more efficient solution.
Thanks.