-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iTwin Reality Data integration #12334
base: main
Are you sure you want to change the base?
Conversation
Thank you for the pull request, @jjspace! ✅ We can confirm we have a CLA on file for you. |
@ggetz I know we discussed it this morning but can you do a quick pass on the API here just to confirm it looks good? then I'll start adding tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall API looks good @jjspace! Just a few comments.
Other: "Other", | ||
}); | ||
|
||
ITwinPlatform.SupportedRealityDataTypes = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this and ITwinPlatform.RealityDataType
be marked private
for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I shifted this supported list into the only function that uses it. RealityDataType
cannot be made private if I want to set it as the type of the param in createTilesetForRealityDataId
because of the way types get generated and skipped for private
@ggetz I've added tests now and I think addressed all your comments above. Should be ready for another look and I think it's close to done if not already there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good @jjspace!
I noticed that the reality mesh looks a bit blurry at the default settings. I was getting a comparable visual to other photogrammetry tilesets after setting the max SSE to 4
—
realityMesh.maximumScreenSpaceError = 4;
I'm guessing this may be because the geometric error of the tileset is balanced against the iTwin viewer, what may have different tile selection metrics. Have you seen the same for other Reality Data meshes?
What do you think of passing a default of 4
for all with the type of RealityMesh3DTiles
?
* | ||
* If the <code>type</code> or <code>rootDocument</code> are not provided this function | ||
* will first request the full metadata for the specified reality data to fill these values. | ||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with createTilesetFromIModelId
.
* | |
* | |
* @experimental This feature is not final and is subject to change without Cesium's standard deprecation policy. |
Description
This PR is building off of #12289 to add an easy function to load Reality Data meshes. Currently we are only supporting 3D Tiles meshes and pointcloud types of Reality Data to keep the initial integration simple. More can be added in the future but they will require different datasources and constructors in CesiumJS and will require a little more thought on how to design the API.
Issue number and link
No issue
Testing plan
Author checklist
CONTRIBUTORS.md
CHANGES.md
with a short summary of my change