Separate reference matrix computation from ImageBasedLighting
#10243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
ImageBasedLighting
was introduced in #10226, it included areferenceMatrix
getter and setter that was used in recomputingiblReferenceFrameMatrix
. However, thereferenceMatrix
will be different for different models, so if multiple models use the same IBL with different model matrices, the IBL matrix that they use will be incorrect. Instead, models should manage their owniblReferenceFrameMatrix
variables.@ptrgags can you review?