Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests cause browser to go full screen #8103

Closed
mramato opened this issue Aug 24, 2019 · 0 comments · Fixed by #8104
Closed

Unit tests cause browser to go full screen #8103

mramato opened this issue Aug 24, 2019 · 0 comments · Fixed by #8104
Labels
good first issue An opportunity for first time contributors

Comments

@mramato
Copy link
Contributor

mramato commented Aug 24, 2019

Sometimes running the unit tests causes the browser to go into full screen mode and stay there. I'm guessing our fullscreen unit tests are to blame. Doesn't appear to happen every time, but run http://localhost:8080/Specs/SpecRunner.html?spec=Core%2FFullscreen a couple times and it will happen.
@mramato mramato added the good first issue An opportunity for first time contributors label Aug 24, 2019
mramato added a commit that referenced this issue Aug 24, 2019
@mramato
Stop actually requesting full screen in unit tests
66caea0 
Uses a jasmine spy to avoid actually making the browser go full screen.
The test was also showing a console exception the way it was written
before.

Fixes #8103
@mramato mramato mentioned this issue Aug 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue An opportunity for first time contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop actually requesting full screen in unit tests CesiumGS/cesium
1 participant
@mramato