Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GroundPrimitive materials and Polylines on Terrain not available when classifying 3D Tilesets #6636

Closed
likangning93 opened this issue May 29, 2018 · 6 comments

Comments

@likangning93
Copy link
Contributor

GroundPrimitive materials aren't available for classifying 3D Tilesets because the depth information for that isn't available in the GroundPrimitive pass. There's also the possibility that shadow volumes might not be tall enough, but in practice I think that's a non-issue at the moment because our shadow volumes are taller than they need to be.

I think I have support hacked up here: https://github.com/likangning93/cesium/tree/groundPrimitiveMaterials3DTiles

But it needs consideration by someone who knows more about the overall renderer.

@mramato
Copy link
Contributor

mramato commented May 29, 2018

Do we probably document this lack of functionality in CHANGES (where it was introduced) and in any related API dealing with it?

@likangning93
Copy link
Contributor Author

@mramato it's documented

@likangning93 likangning93 changed the title GroundPrimitive materials not available when classifying 3D Tilesets GroundPrimitive materials (and upcoming polylines on terrain) not available when classifying 3D Tilesets Jun 11, 2018
@likangning93
Copy link
Contributor Author

Polylines on terrain on 3D Tilesets

The polylines on terrain algorithm currently in #6615 depends on the depth buffer, so that's a similar implementation hurdle for getting Polylines on Terrain to work on 3D Tiles.

Bigger problem though is that the geometry generation for Polylines on Terrain makes a lot of 2.5D assumptions, and won't behave as-expected for, say, drawing lines on the sides of buildings or the undersides of overpasses. There's a similar problem for GroundPrimitives except that you can use ClassificationPrimitives without materials to do this sort of thing for most use cases.

@likangning93 likangning93 changed the title GroundPrimitive materials (and upcoming polylines on terrain) not available when classifying 3D Tilesets GroundPrimitive materials and Polylines on Terrain not available when classifying 3D Tilesets Jul 5, 2018
@ggetz
Copy link
Contributor

ggetz commented Jul 20, 2018

@OmarShehata
Copy link
Contributor

Just came up again on the forum as a way to label parts of 3D Tiles.

@cesium-concierge
Copy link

Congratulations on closing the issue! I found these Cesium forum links in the comments above:

https://groups.google.com/forum/#!topic/cesium-dev/2h_uVa6JHAM
https://groups.google.com/d/msg/cesium-dev/HsC4mRtcm8E/O717hmi1BgAJ

If this issue affects any of these threads, please post a comment like the following:

The issue at #6636 has just been closed and may resolve your issue. Look for the change in the next stable release of Cesium or get it now in the master branch on GitHub https://github.com/AnalyticalGraphicsInc/cesium.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants