Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glTF lighting change in 1.36 #5787

Closed
hpinkos opened this issue Aug 28, 2017 · 3 comments
Closed

glTF lighting change in 1.36 #5787

hpinkos opened this issue Aug 28, 2017 · 3 comments

Comments

@hpinkos
Copy link
Contributor

hpinkos commented Aug 28, 2017

The CesiumMilkTruck-kmc model is completely black when not lit by the sun in 1.36. This was not the case in 1.36. Was this change intentional? @lilleyse

1.35:
image

1.36:
image

Load this example and move the timeline so it's night.

var viewer = new Cesium.Viewer('cesiumContainer');

var position = Cesium.Cartesian3.fromDegrees(-123.0744619, 44.0503706, 0);
var heading = Cesium.Math.toRadians(135);
var pitch = 0;
var roll = 0;
var hpr = new Cesium.HeadingPitchRoll(heading, pitch, roll);
var orientation = Cesium.Transforms.headingPitchRollQuaternion(position, hpr);

var entity = viewer.entities.add({
    position : position,
    orientation : orientation,
    model : {
        uri : '../../SampleData/models/CesiumMilkTruck/CesiumMilkTruck-kmc.glb',
        minimumPixelSize : 128,
        maximumScale : 20000
    }
});
viewer.trackedEntity = entity;
@lilleyse
Copy link
Contributor

Should be better now - fixed here: CesiumGS/gltf-pipeline#313
dark

@pjcozzi
Copy link
Contributor

pjcozzi commented Aug 31, 2017

OK to close?

@lilleyse
Copy link
Contributor

Yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants