Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we still be shipping the built Cesium Viewer? #3127

Closed
mramato opened this issue Oct 26, 2015 · 2 comments
Closed

Should we still be shipping the built Cesium Viewer? #3127

mramato opened this issue Oct 26, 2015 · 2 comments

Comments

@mramato
Copy link
Contributor

mramato commented Oct 26, 2015

We currently ship with a built copy of the Cesium Viewer and even mention it as "ready for deployment" on our website's download page. This is misleading since the Cesium Viewer contains the default Bing key and can't be deployed as-is without violating usage policy.

I'm not even sure how many people actually ever use the built version either (or why you would use it other than for development). Should we just stop shipping the built version? It would probably shrink our overall zip file size a bit as well. If we want to continue to ship the built version, we'll need a way to specify the Bing key via a configuration file that Cesium Viewer looks for.

@pjcozzi
Copy link
Contributor

pjcozzi commented Oct 26, 2015

Removing it is OK with me.

@emackey
Copy link
Contributor

emackey commented Oct 26, 2015

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants